[Bug 796885] gst-plugins-base: Yocto build error: 'gbm.h' not found, 'EGL_PLATFORM_GBM_MESA' undeclared

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796885

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ystreet00 at gmail.com

--- Comment #6 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
(In reply to n.wesp from comment #5)
> (In reply to Matthew Waters (ystreet00) from comment #3)
> > Review of attachment 373187 [details] [review] [review]:
> > 
> > Not quite :)
> > 
> > ::: gst-libs/gst/gl/Makefile.am
> > @@ +163,3 @@
> >  	$(GST_ALL_LDFLAGS) \
> > +	$(GST_LT_LDFLAGS) \
> > +	$(GBM_LDFLAGS)
> > 
> > $GBM_LDFLAGS) isn't something that's set in configure.  You want to add
> > $(GBM_LIBS) to the libgstgl_ at GST_API_VERSION@_la_LIBS variable instead.
> > 
> > ::: gst-libs/gst/gl/egl/Makefile.am
> > @@ +32,3 @@
> >  	$(GST_LIB_LDFLAGS) \
> > +	$(GST_ALL_LDFLAGS) \
> > +	$(GBM_LDFLAGS)
> > 
> > ditto
> 
> So my changes within your update looks okay?
> Will the main repo with v1.14.1 be updated, so that I don't have to add an
> patch in a '*.bb_append' file?

Ah, actually. GBM_CFLAGS/LIBS should be added to GL_CFLAGS/LIBS in m4/gst-gl.m4
instead alongside the DRM_CFLAGS addition.

If you want to create a patch for that, I can merge it into the main repo :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.