[Bug 796863] vaapih264dec: H264 parse stops if missing an SPS/PPS

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796863

--- Comment #33 from Matteo Valdina <matteo.valdina at gmail.com> ---
Created attachment 373248
  --> https://bugzilla.gnome.org/attachment.cgi?id=373248&action=edit
Requests GstForceKeyUnit to the upstream in case of parse/decode error.

Requests GstForceKeyUnit to the upstream in case of parse/decode error.

In the case of decode error, there is a change that affects other cases.
The "GstFlowret value was never initialized in some condition and so it was
undefined.

I saw by experience that it was 0 (GST_FLOW_OK) but this is a random behavior
and tied to the specific compiler/cpu/kernel and other factors.
I added a default value that it makes sense for my understanding of this
codebase. But I'm probably wrong.

At least I think it is better because it is a defined behavior.

I saw that there are other functions that have this issue like
gst_vaapidecode_push_all_decoded_frames where "ret" is returned in the default
switch with the un-initialized value.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.