[Bug 791771] opusenc, opusdec: add option to disable phase inversion

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=791771

Hector Martin <marcan at marcan.st> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #5 from Hector Martin <marcan at marcan.st> ---
I see the patch is for opusdec only. Can we get the same feature implemented
for opusenc? That was actually my use case: I'm encoding audio with gstreamer
for WebRTC distribution, and Chrome was spuriously downmixing it (due to a bad
RTP descriptor, but that's another story), causing extremely bad audio quality.
I want to ensure that regardless of what clients do, I don't get this effect.

In fact disabling phase inversion by default (unconditionally, not just for
mono output) in the decoder may not be the best idea, since it'll reduce stereo
imaging for streams that use it. I was thinking disabling it in the encoder
might be a good idea, since it ensures streams sound good regardless of what
the decoder does or any downmixing that occurs. But if the decoder thinks the
channel count is 2 then it probably makes sense to leave it on, so that if the
encoder relied on the feature it is used. Of course, if something downstream
ends up downmixing the audio to mono then it'll sound bad, so I guess it
depends on how likely we think that will be.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.