[Bug 792131] rtspsrc: add an action signal to send SET_PARAMETER

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Aug 14 06:48:07 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=792131

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373308|none                        |needs-work
             status|                            |

--- Comment #19 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 373308:
 --> (https://bugzilla.gnome.org/review?bug=792131&attachment=373308)

::: gst/rtsp/gstrtspsrc.c
@@ +1073,3 @@
+      G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION, G_STRUCT_OFFSET (GstRTSPSrcClass,
+          get_parameter), NULL, NULL, g_cclosure_marshal_generic,
+      G_TYPE_BOOLEAN, 3, G_TYPE_STRING, G_TYPE_STRING, G_TYPE_POINTER);

This should be GST_TYPE_PROMISE, not GST_TYPE_POINTER

@@ +1091,3 @@
+      G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION, G_STRUCT_OFFSET (GstRTSPSrcClass,
+          get_parameters), NULL, NULL, g_cclosure_marshal_generic,
+      G_TYPE_BOOLEAN, 3, G_TYPE_STRV, G_TYPE_STRING, G_TYPE_POINTER);

And here

@@ +1111,3 @@
+          set_parameter), NULL, NULL, g_cclosure_marshal_generic,
+      G_TYPE_BOOLEAN, 4, G_TYPE_STRING, G_TYPE_STRING, G_TYPE_STRING,
+      G_TYPE_POINTER);

And here

@@ +9036,3 @@
+  {
+
+    if (req) {

Shouldn't we expire/fail the promise in all other cases here or does that
automatically happen later?

Same about the other functions below

@@ +9074,3 @@
+
+    GST_ELEMENT_ERROR (src, LIBRARY, INIT, (NULL),
+        ("Could not create request. (%s)", str));

All the errors here, do they have to be fatal (error messages are fatal)? Or
could we instead just continue normally and only signal an error via the
promise?

@@ +9083,3 @@
+
+    GST_ELEMENT_ERROR (src, LIBRARY, INIT, (NULL),
+        ("Could add content header. (%s)", str));

"Could not" instead of "Could" I assume? Also above :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list