[Bug 793441] rtsp-stream: client transport is not updated for multicast clients

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793441

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373253|none                        |needs-work
             status|                            |

--- Comment #68 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 373253:
 --> (https://bugzilla.gnome.org/review?bug=793441&attachment=373253)

This should probably get a link to
https://bugzilla.gnome.org/show_bug.cgi?id=796917 in the commit message and a
FIXME comment somewhere in the code?

Looks fine otherwise

::: gst/rtsp-server/rtsp-stream.c
@@ +1642,3 @@
+  client->rtp_port = rtp_port;
+  client->add_count = 1;
+  priv->mcast_clients = g_list_prepend (priv->mcast_clients, client);

Shouldn't this also be configured on multiudpsink at some point, or does that
happen elsewhere already? Same for removal.

It looks like this code only keeps track of the addresses but does not actually
configure them on the sink (and the source for RTCP or RTP RECORD or
backchannel is broken anyway, see above, but it was so before anyway)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.