[Bug 796953] Add option to enable shallow fetch optimization

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796953

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373322|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 373322:
 --> (https://bugzilla.gnome.org/review?bug=796953&attachment=373322)

::: cerbero/build/source.py
@@ +215,3 @@
+            commit = self.config.recipe_commit(self.name) or self.commit
+            if self.config.use_shallow_fetch and commit.startswith('origin/'):
+              git.fetch_ref(self.repo_dir, 'origin', commit[7:], fail=False)

Why limit it to "origin/"? What's wrong with doing it for specific commits or
tags (note: tags don't specify the remote!), or other remotes than origin?

::: recipes/taglib.recipe
@@ -8,3 @@
     version = '1.11.1'
     stype = SourceType.TARBALL
-    url = 'https://taglib.org/releases/taglib-%(version)s.tar.gz'

This should be a separate commit

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.