[Bug 792131] rtspsrc: add an action signal to send SET_PARAMETER

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=792131

--- Comment #21 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to ulfo from comment #20)
> 
> Yes, it is better to pass on the errors via the promise. Should we do that
> for all potential errors in
> gst_rtspsrc_set_parameter/gst_rtspsrc_get_parameter?

All errors that don't mean that the element will stop functioning afterwards.
If the server closes the connection for example then that's an error.

> if (req) { 
> 
> is unnecessary (req == NULL is a major bug) but currently "promises" can
> only expire when gst_rtspsrc_cleanup is called. So the question is, should a
> promise just live in the queue for a limited period of time?

I wouldn't time them out, but if a promise is in the queue and the
corresponding message is sent to the server then it should be handled on
response. Either by a successful or error reply.

> Plus, should we limit the number of SET/GET requests in the queue?

No limit seems fine, let the application handle that

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.