[Bug 793441] rtsp-stream: client transport is not updated for multicast clients

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793441

--- Comment #75 from Patricia Muscalu <patricia at axis.com> ---
(In reply to Patricia Muscalu from comment #72)
> (In reply to Sebastian Dröge (slomo) from comment #68)
> > Review of attachment 373253 [details] [review] [review]:
> > 
> > This should probably get a link to
> > https://bugzilla.gnome.org/show_bug.cgi?id=796917 in the commit message and
> > a FIXME comment somewhere in the code?
> > 
> > Looks fine otherwise
> > 
> > ::: gst/rtsp-server/rtsp-stream.c
> > @@ +1642,3 @@
> > +  client->rtp_port = rtp_port;
> > +  client->add_count = 1;
> > +  priv->mcast_clients = g_list_prepend (priv->mcast_clients, client);
> > 
> > Shouldn't this also be configured on multiudpsink at some point, or does
> > that happen elsewhere already? Same for removal.
> > 
> > It looks like this code only keeps track of the addresses but does not
> > actually configure them on the sink (and the source for RTCP or RTP RECORD
> > or backchannel is broken anyway, see above, but it was so before anyway)
> 
> Your are absolutely right that some parts are missing here. The whole idea
> is to add the mcast address on SETUP (during the client transport
> configuration). What's missing here is that add_client and remove_client
> functions, that actually send signals to multiudpsink, don't check if the
> requested destination exists in the mcast_clients array. The destination
> should be removed as well "remove" is sent to the sink.

Wait, there already exists remove_mcast_client_addr() function, provided in
this patch, that actually removes the address on client removal. I'll only add
additional checks in add_client()

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.