[Bug 793441] rtsp-stream: client transport is not updated for multicast clients

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Aug 14 09:27:53 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=793441

--- Comment #78 from Patricia Muscalu <patricia at axis.com> ---
(In reply to Patricia Muscalu from comment #70)
> (In reply to Sebastian Dröge (slomo) from comment #66)
> > Review of attachment 373251 [details] [review] [review]:
> > 
> > generally looks good, just one question
> > 
> > ::: gst/rtsp-server/rtsp-stream.c
> > @@ +1475,3 @@
> >      g_clear_object (&rtp_socket);
> > +    if (transport_settings_defined)
> > +      goto transport_settings_error;
> > 
> > What if we already have been bound to that UDP port and the corresponding
> > elements could be used for this new client too? Is that covered somewhere?
> 
> Good point. Let me check.

This is actually the case when bind() fails. So in the client-settings case
we just return with an error message, otherwise we try to find any free
address/ports pairs in the address pool.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list