[Bug 796519] Add AV1 codec parser

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796519

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373286|none                        |reviewed
             status|                            |

--- Comment #42 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 373286:
 --> (https://bugzilla.gnome.org/review?bug=796519&attachment=373286)

as this parser needs to allocate memory and free it, perhaps it is required to
add the glib's annotation for autoclean pointers.

::: gst-libs/gst/codecparsers/gstav1parser.c
@@ +167,3 @@
+#define gst_av1_bit_reader_skip(br, nbits) if
(!gst_bit_reader_skip(br,(nbits))) { \
+                                             GST_LOG("Skip Bit Error at line
%d",__LINE__); \
+                                             return
GST_AV1_PARSER_SKIPBITS_ERROR; \

inlined function instead?

@@ +186,3 @@
+
+static gint
+gst_av1_helpers_FloorLog2 (guint32 x)

As this is an inside helper, I would keep the low_case format (not CamelCase),
without the namespace
for example,

_floor_log2(..

@@ +198,3 @@
+
+static gint
+gst_av1_helper_TileLog2 (gint blkSize, gint target)

ditto

_tile_log2(..

@@ +207,3 @@
+
+static gint
+gst_av1_helper_InverseRecenter (gint r, gint v)

ditto

_inverse_recenter(..

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.