[Bug 796963] Rework SRT plugin to unify client/server and add features

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Aug 15 03:14:10 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=796963

--- Comment #3 from Roman Diouskine <rdiouskine at haivision.com> ---
Hello Nicolas, thanks for taking a look.

"glib 2.54 compatibility" means a very confusing comment :) Sorry, I will
remove that.

I do understand very well that the patch is hard to review due to the number of
changes introduced. I don't feel proud about that part at all. Unfortunately,
it ended up this way after a fairly long internal project with many changes
required to make the plugin usable in a product. Reworking this into a smaller
patch series will take much work and is error-prone. I asked Olivier's opinion
and he suggested to push the "big patch" and see how that goes first.

If you could kindly take a look at the code and see if there is a way the
changes can be used without the splitting I would greatly appreciate that as it
would save a lot of time on my side. If the conclusion will be that splitting
is absolutely necessary I will do my best to get that accomplished.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list