[Bug 796977] avwait: Start video and audio together if audio starts late

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796977

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373359|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 373359:
 --> (https://bugzilla.gnome.org/review?bug=796977&attachment=373359)

::: gst/timecode/gstavwait.c
@@ +754,3 @@
   }
+  while (self->mode == MODE_VIDEO_FIRST
+      && self->first_audio_running_time == GST_CLOCK_TIME_NONE) {

Need to check for flushing flag here, and probably EOS too (and set such flags)

Flushing the audio pad should not unblock the video pad, flushing the video pad
should not unblock the audio pad. They should only unblock the corresponding
pad itself.

Shutting down the element should unblock both pads.

@@ +873,3 @@
           GST_TIME_ARGS (self->running_time_to_wait_for), inbuf);
+      if (self->mode != MODE_VIDEO_FIRST ||
+          self->first_audio_running_time <= running_time) {

Probably need to handle the case here where audio ended before the video
running time?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.