[Bug 795854] uridecodebin3: setting suburi property has no effect
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Thu Aug 16 18:22:44 UTC 2018
https://bugzilla.gnome.org/show_bug.cgi?id=795854
Thibault Saunier <tsaunier at gnome.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #371755|none |reviewed
status| |
--- Comment #5 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 371755:
--> (https://bugzilla.gnome.org/review?bug=795854&attachment=371755)
::: gst/playback/gsturidecodebin3.c
@@ -854,1 +876,4 @@
- g_value_set_string (value, dec->suburi);
+ if (dec->current && dec->current->main_item) {
+ g_value_set_string (value, dec->current->main_item->uri);
+ } else {
+ g_value_set_string (value, "");
Can you just use `dec->uri` here?
@@ -1015,1 +1038,2 @@
dec->play_items = g_list_append (dec->play_items, item);
+ dec->current = dec->play_items->data;
That was never set at all right? I have the impression something is missing in
term of ownership here.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list