[Bug 796984] Support hevc encode low latency B frame.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796984

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373367|none                        |reviewed
             status|                            |

--- Comment #2 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 373367:
 --> (https://bugzilla.gnome.org/review?bug=796984&attachment=373367)

Hi Fei,

Perhaps we need to complete the commit log information:  What Intel hardware?
using which vaapi backend?

::: gst-libs/gst/vaapi/gstvaapiencoder_h265.c
@@ +824,3 @@
       WRITE_UINT32 (bs,
+          slice_param->slice_fields.
+          bits.slice_loop_filter_across_slices_enabled_flag, 1);

this change is related with code style, not with the purpose of this patch. I
would remove it.

@@ +1748,3 @@

+    slice_param->slice_fields.
+        bits.slice_loop_filter_across_slices_enabled_flag = TRUE;

ditto.

@@ +2769,3 @@
+          "Low latency B will change P frame into predictive B frame",
+          FALSE, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
+

I'm not very fond to add properties for every hardware specific requirement,
because properties are like APIs, we have to keep them, and maintain them, as
soon as they are public almost forever.

Are you sure there isn't a way to query vaapi backend or an API to query the
chipset and set all this hacks???

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.