[Bug 796647] qtdemux: PIFF track encryption box support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796647

--- Comment #3 from Philippe Normand <philn at igalia.com> ---
Review of attachment 372757:
 --> (https://bugzilla.gnome.org/review?bug=796647&attachment=372757)

::: gst/isomp4/qtdemux.c
@@ +10076,3 @@
+        return FALSE;
+      }
+      };

I skip 16 bits representing the UUID, and then 12 (8 + 4) representing the
version and flags fields. So I think we're good. I can add a test checking
tenc_data is still a valid pointer though.

@@ +10084,3 @@
+        isEncrypted = FALSE;
+      } else if (algorithm_id == 1) {
+        GST_ERROR_OBJECT (qtdemux, "schi box does not contain tenc box, "

Yes, actually this code is copy-pasted in 2 places now, I'll refactor this and
store the info in default_properties :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.