[Bug 771525] gst-rtsp-server: Poor performance with interleaved RTSP due to missing buffer list support and merging of all memories in buffers

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=771525

Nicolas Dufresne (ndufresne) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373368|none                        |needs-work
             status|                            |

--- Comment #23 from Nicolas Dufresne (ndufresne) <nicolas at ndufresne.ca> ---
Review of attachment 373368:
 --> (https://bugzilla.gnome.org/review?bug=771525&attachment=373368)

::: gst/rtsp-server/rtsp-stream-transport.c
@@ +219,3 @@
+ *
+ * Install callbacks that will be called when data for a stream should be sent
+ * to a client. This is usually used when sending RTP/RTCP over TCP.

This need a Since mark, same for other new symbols.

::: gst/rtsp-server/rtsp-stream.c
@@ +2424,3 @@
+    n_messages += 1;
+  if (buffer_list)
+    n_messages += gst_buffer_list_length (buffer_list);

Can you really have both buffer and buffer_list set ? I think using else if ()
if not would be better. If it's the case, how do we know we should send the
buffer first ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.