[Bug 796963] Rework SRT plugin to unify client/server and add features

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796963

--- Comment #9 from Roman Diouskine <rdiouskine at haivision.com> ---
Attached the ticket is the second iteration of the patch with all the noted
issues fixed except two for which I need some guidance:

> ::: ext/srt/gstsrtsrc.h
> @@ +57,3 @@
> +
> +  /*< private >*/
> +  gpointer _gst_reserved[GST_PADDING];
> 
> No need for reserved, this is all private.

There is another private structure GstSRTSrcPrivate that gets added to
GstSRTSrc in gstsrtsrc.c, I think I need to reserve some space for this to work
properly. I could be wrong, please advice.

> ::: ext/srt/gstsrtsink.c
> @@ +385,3 @@
> +  priv->loop = g_main_loop_new (priv->context, TRUE);
> +
> +  priv->thread = g_thread_try_new ("srtsink", thread_func, self, &error);
> 
> This thread won't be catched through GST_MESSAGE_STREAM_STATUS / ENTER /
> LEAVE etc. As you do custom threading, you need to implement this yourself.

The custom thread in question does not, in fact, touch the stream data at all.
What it does is managing the list of remote SRT "clients" or "destinations"
allowing them to dynamically connect/disconnect. The stream data is then
iteratively sent to that list when 'render' callback is invoked. Do you think
that qualifies for STREAM_STATUS logic? Not too sure what that would do...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.