[Bug 796985] kmssink modesetting fails for multi-planar buffers

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796985

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vjaquez at igalia.com

--- Comment #4 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
(In reply to Nicolas Dufresne (ndufresne) from comment #3)
> Review of attachment 373369 [details] [review]:
> 
> ::: sys/kms/gstkmssink.c
> @@ -441,3 @@
>      goto connector_failed;
>  
> -  fb = drmModeGetFB (self->fd, fb_id);
> 
> On the plus side, we found that drmModeGetFB returns a handle that must be
> freed, and was currently leaked.

It won't matter any more, but as far I see in the code, it was freed: 

https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/sys/kms/gstkmssink.c#n468

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.