[Bug 796919] osxaudiosink does not work on iOS 12

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796919

Nicolas Dufresne (ndufresne) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373418|none                        |needs-work
             status|                            |

--- Comment #6 from Nicolas Dufresne (ndufresne) <nicolas at ndufresne.ca> ---
Review of attachment 373418:
 --> (https://bugzilla.gnome.org/review?bug=796919&attachment=373418)

Ok, about the commit message, should be in the following form:


  osxcoreaudio: Short description
  <empty line>
  Longer description
  <empty line>
  <bug URI if available>

The short description should not exceed 80 characters.

::: sys/osxaudio/gstosxcoreaudio.c
@@ +457,3 @@
   }

+  GstAudioChannelPosition pos[GST_OSX_AUDIO_MAX_CHANNEL];

In general we try not to mix code and declaration, please move this at the
start of your scope ({).

@@ +461,3 @@
     if (!gst_core_audio_parse_channel_layout (layout, &channels,
&channel_mask,
             pos)) {
       GST_WARNING ("Failed to parse channel layout");

Maybe the warning should explain a bit what is going to happen, specially that
it won't error out.

@@ -463,3 @@
             pos)) {
       GST_WARNING ("Failed to parse channel layout");
-      goto error;

Is this label still used ? Just double checking.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.