[Bug 790696] matroskademux: seek ends up in cluster with no key-frame

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=790696

--- Comment #29 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
> Sorry for being dense, but I am not able to cherry-pick form the link you
> attached. Can not find the
> "matroskademux-scan-clusters-for-keyframe-2"-branch. The link seems to be on
> another git.

This should work:

  $ git remote add tpm-fdo git://people.freedesktop.org/~tpm/gst-plugins-good
    (I'm sure there's an http url too, but don't know it right now)

  $ git fetch tpm-fdo

  $ gitk tpm-fdo/matroskademux-scan-clusters-for-keyframe-2 &


> Is the intention that all patches should be applied, or is the
> intention to pick the ones that "we" need?

You probably don't need the two first ones ("WIP: gdkpixbufsink-test") and the
last one ("matroskademux: implement keyframe search also without cluster prev
size") is also optional for you, but shouldn't do any harm.

I also forgot to mention that I ran into some issues when testing the initial
patch: when scrubbing/seeking towards the end of the file (beyond start of last
cluster? don't remember) I could easily trigger fatal seeking errors (though
I'm sure they could be fixed of course). I could only trigger it with a certain
sequence of seeks though.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.