[Bug 789475] omx: wait for flush complete and buffers being released when flushing

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=789475

Guillaume Desmottes <gdesmott at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #362611|needs-work                  |none
             status|                            |
 Attachment #362611|0                           |1
        is obsolete|                            |

--- Comment #18 from Guillaume Desmottes <gdesmott at gnome.org> ---
Created attachment 373432
  --> https://bugzilla.gnome.org/attachment.cgi?id=373432&action=edit
omx: wait for flush complete and buffers being released when flushing

When flusing we should wait for OMX to send the flush command complete event
AND all ports being released.
We were stopping as soon as one of those condition was met.

Fix a race between FillThisBufferDone/EmptyBufferDone and the flush
EventCmdComplete messages. The OMX implementation is supposed to release
its buffers before posting the EventCmdComplete event but the ordering
isn't guaranteed as the FillThisBufferDone/EmptyBufferDone and
EventHandler callbacks can be called from different threads (cf 2.7
'Thread Safety' in the spec).

Only wait for buffers currently used by OMX as some buffers may not be
in the pending queue because they are held downstream.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.