[Bug 787206] matroska-demux: incorrectly interprets FlagInterlaced field

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=787206

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |t.i.m at zen.co.uk
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.15.1
            Summary|matroska-demux.c            |matroska-demux: incorrectly
                   |incorrectly interprets      |interprets FlagInterlaced
                   |FlagInterlaced-field        |field

--- Comment #11 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
> Your argumentations seems correct. Following it I'd propose the following
> mapping:
> 
> <absent> -> no interlace-mode caps
> 0        -> no interlace-mode caps
> 1        -> interlace-mode=interlaced
> 2        -> interlace-mode=progressive
> 
> This would require adding another flag or, better, an enum to signal the
> no-information state.

Only saw your patch after I had already implemented this Sebastian, sorry!

I think we should not make up information, so even if it later gets implicitly
assumed to be progressive we shouldn't put progressive mode into the demuxer
caps unless we know, IMHO:

Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Thu Aug 23 22:57:35 2018 +0200

    matroska: fix handling of FlagInterlaced

    This is an enum not a boolean, and a value of 2 signals
    that the video is progressive, but we would mistakenly set
    interlace-mode=mixed on the output caps.

    https://bugzilla.gnome.org/show_bug.cgi?id=787206

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.