[Bug 797007] Warning log printed when running glvideomixer command

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797007

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373424|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 373424:
 --> (https://bugzilla.gnome.org/review?bug=797007&attachment=373424)

::: gst/parse/grammar.y
@@ +310,3 @@
 }

+pthread_mutex_t mutex;

Use the GLib mutex API here. PThread does not exist everywhere

@@ +345,3 @@
+    pthread_mutex_lock(&mutex);
+    if (g_signal_handler_is_connected (child_proxy, set->signal_id)) {
+      g_signal_handler_disconnect (child_proxy, set->signal_id);

>From where was it otherwise disconnected before? From which code, where was it
called from and why from different threads?

Should we maybe simply set signal_id to 0 after disconnecting and checking for
that (and protect it with a mutex)?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.