[Bug 796988] rtsp-client: We allow reused channel numbers for interleaved

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796988

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373396|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 373396:
 --> (https://bugzilla.gnome.org/review?bug=796988&attachment=373396)

::: gst/rtsp-server/rtsp-client.c
@@ +2091,3 @@
+              GINT_TO_POINTER (ct->interleaved.max))) {
+        gst_rtsp_session_media_alloc_channels (ctx->sessmedia,
+            &ct->interleaved);

This would loop forever if all 256 ids are taken already. In all other cases,
can this actually loop multiple times? Shouldn't the allocation of the channels
always give free, valid values?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.