[Bug 797037] decklink: Only use drop-frame flag for 29.97 and 59.94 FPS

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797037

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373482|none                        |accepted-commit_now
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 373482:
 --> (https://bugzilla.gnome.org/review?bug=797037&attachment=373482)

::: sys/decklink/gstdecklinkvideosrc.cpp
@@ +760,3 @@
               GST_VIDEO_TIME_CODE_FLAGS_INTERLACED);
+        if (bmode->fps_d == 1001) {
+          if (bmode->fps_n == 30000 || bmode->fps_n == 60000)

These two framerates also exist non-drop-frame. Please add a comment here why
we nonetheless always assume them to be drop-frame.

Otherwise seems fine

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.