[Bug 797037] decklink: Only use drop-frame flag for 29.97 and 59.94 FPS

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797037

Vivia Nikolaidou <vivia at ahiru.eu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373483|none                        |committed
             status|                            |

--- Comment #5 from Vivia Nikolaidou <vivia at ahiru.eu> ---
Review of attachment 373483:
 --> (https://bugzilla.gnome.org/review?bug=797037&attachment=373483)

commit 4ca76e0c123b37175dd76057dbb45c96b47e7477 (HEAD -> upstream_master,
upstream/master)
Author: Vivia Nikolaidou <vivia at ahiru.eu>
Date:   Tue Aug 28 15:04:53 2018 +0300

    decklink: Only use drop-frame flag for 29.97 and 59.94 FPS

    Otherwise it can cause errors in gstvideotimecode.c because drop-frame
    is not defined for any other frame rate (e.g. 24000/101)

    https://blog.frame.io/2017/07/17/timecode-and-frame-rates/

    https://bugzilla.gnome.org/show_bug.cgi?id=797037

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.