[Bug 787124] vaapih264dec: segmentation fault when decoding kodi sample

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=787124

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373468|none                        |reviewed
             status|                            |

--- Comment #23 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 373468:
 --> (https://bugzilla.gnome.org/review?bug=787124&attachment=373468)

Great! Thanks!

Just a couple nitpicks:

in the commit summary, we have being using a format. In this case it would be:
"libs: decoder: h264: avoid use picture after free it"

::: gst-libs/gst/vaapi/gstvaapidecoder_h264.c
@@ +943,3 @@
     return FALSE;

+  gst_vaapi_mini_object_ref (GST_VAAPI_MINI_OBJECT (found_picture));

what about using gst_vaapi_picture_ref() for sake of homogeneity. Later, if we
decide to change the gstvaapiminiobject to gstminiobject, we could search and
replace easily.

@@ +958,3 @@
+
+done:
+  gst_vaapi_mini_object_unref (GST_VAAPI_MINI_OBJECT (found_picture));

ditto, gst_vaapi_picture_unref()

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.