[Bug 766898] player: Add a message queue API in addition to the signals

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766898

--- Comment #23 from Stephan Hesse <tchakabam at gmail.com> ---
> There's not actually a problem here if refcounting is done properly.

Obviously. 

Also, I row back on my previous statement that it wouldn't be "sane" having a
bus ref if the player instance is already free'd. That would just be OK, the
bus just wouldn't get any new messages. But it might still have some to be
read.  

There might be a scenario where one thread only reads from the bus and another
deals with the player API itself. And then the player might get destroyed while
the other thread is still dealing with reading messages. This of course
wouldn't be an issue at all if we give out a strong ref or if ref count is
increased appropriatly somewhere else, i.e by the app. Same goes for the player
instance ref itself, since it's a GObject as much as the GstBus is.

> That said, it would be better to return a strong reference from the GstPlayer API for consistency reasons.

Agreed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.