[Bug 715192] videodecoder: Cannot accumulate buffer while downstream is blocked

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Aug 31 21:12:07 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=715192

--- Comment #27 from Nicolas Dufresne (ndufresne) <nicolas at ndufresne.ca> ---
While it would also be nice to do the same while pushing serialized event, it
does not seems strictly needed to achieve decent performance here.

What was very key here, was to control the case where the frame being _finish()
is that last one. Basically, while pushing, if some events comes in, they
should be appended to that frame, as we already pushed those pending events.
But this was already covered, since we remove the frame from the internal list
before we get there. The aliasing of the srcpad stream lock should cover most
worries. At the moment we have two decoder/encoder implementation, both mimics
each others, and for both, concurrent negotiation and finish_frame is unlikely.
The internal data always get drained before such a situation. I also think
these patches should hold for a while, at which point we'll probably have to
fork it to remove that lock and simply find a better workflow for threaded
decoders/encoders.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list