[Bug 791986] aggregator: add a drain vmethod

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=791986

--- Comment #18 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> ---
(In reply to Mathieu Duponchelle from comment #15)
> Review of attachment 366027 [details] [review]:
> 
> Apart from the concern I had with the queuing of seeks, this patch looks
> good to go to me, couldn't see any problems with locking in particular.
> 
> I assumed basesrc already handled the chain of events I was worried about,
> if it does not then it does not make much sense to start handling that in
> aggregator :)
> 
> ::: libs/gst/base/gstaggregator.h
> @@ -219,2 +219,5 @@
>   *                     buffers. The passed in query contains the result of
> the
>   *                     downstream allocation query.
> + * @drain:          Optional.
> + *                  Called before a new segment will be sent. If not
> flushing,
> + *                  clip work-in-progress buffer and send it.
> 
> This gets called when we have received all segment dones, not when we send a
> new segment, and whether the next seek will be flushing or not should not
> matter here? From looking at the audiomixer implementation it doens't
> concern itself with flushing concerns and always clips, which makes sense to
> me.

Do you want me to change the wording here?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.