[Bug 757563] audiomixer: issues with seamless looping (missing support for non-flushing seeks)

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=757563

--- Comment #26 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> ---
(In reply to Mathieu Duponchelle from comment #24)
> Review of attachment 366010 [details] [review]:
> 
> Some comments, I also wonder the same thing as Olivier. Second part of the
> commit message should also be edited out :)
> 
> ::: gst-libs/gst/audio/gstaudioaggregator.c
> @@ +1732,2 @@
>    /* Update position from the segment start/stop if needed */
> +  if (agg->segment.position == -1 || agg->segment.position <
> agg->segment.start) {
> 
> How can this happen?

This is the same check as here:
https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst-libs/gst/audio/gstaudioaggregator.c#n436
I don't have a repro right now, but I am sure I run into it since I added the
condition there.

> 
> @@ +1999,3 @@
> +      /* when using live sources, we might get output_offset to be offset +
> 1
> +       * due to rounding errors (?), clip the max_offset to the segment
> +       */
> 
> That seems unrelated, and I'm not sure I understand how this can happen, I
> think it'd better be discussed in a separate issue.

I've extracted the change and will try to come up with a separate repro.

> 
> @@ +2049,3 @@
>    /* send it out */
>    GST_LOG_OBJECT (aagg,
> +      "pushing outbuf %p, timestamp %" GST_TIME_FORMAT ", offset %"
> 
> Could be simplified by just using GST_PTR_FORMAT + the offset instead

Done.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.