[Bug 791674] Continued improvements to AOM plugin

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=791674

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #367791|none                        |needs-work
             status|                            |

--- Comment #21 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 367791:
 --> (https://bugzilla.gnome.org/review?bug=791674&attachment=367791)

::: ext/aom/gstav1enc.c
@@ +139,3 @@
   GST_PAD_SET_ACCEPT_TEMPLATE (GST_VIDEO_ENCODER_SINK_PAD (av1enc));
+
+  av1enc->keyframe_dist = 30;

I don't like this manual, fixed keyframe dist but that's for later I guess :)

@@ +149,3 @@
+
+  if (av1enc->input_state) {
+    gst_video_codec_state_unref (av1enc->input_state);

It should always be unreffed in stop(). It can only exist >= start()

@@ +240,3 @@
+  output_state =
+      gst_video_encoder_set_output_state (encoder,
+      gst_pad_get_pad_template_caps (GST_VIDEO_ENCODER_SRC_PAD (encoder)),

The caps need to be unreffed

@@ +244,3 @@
+  gst_video_codec_state_unref (output_state);
+
+  av1enc->input_state = gst_video_codec_state_ref (state);

If there already is an input_state, you first should unref it

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.