[Bug 791674] Continued improvements to AOM plugin

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=791674

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #367891|none                        |reviewed
             status|                            |

--- Comment #27 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 367891:
 --> (https://bugzilla.gnome.org/review?bug=791674&attachment=367891)

::: ext/aom/gstav1enc.c
@@ +131,3 @@
+  g_object_class_install_property (gobject_class, PROP_CPU_USED,
+      g_param_spec_int ("cpu-used", "CPU Used",
+          "CPU Used. A Value greater than 0 will increase encoder speed at the
expense of quality.",

Not at the expense of CPU usage?

@@ +181,1 @@
+  GST_WARNING_OBJECT (av1enc, "Latency unimplemented");

Why these unrelated changes? Better put them into a separate commit :)

@@ +429,3 @@
+    GST_WARNING_OBJECT (av1enc,
+        "Properties can only be changed when NULL or READY");
+    GST_OBJECT_UNLOCK (av1enc);

I don't think so? cpu-used looks like it can be changed at any time, and things
like bitrate certainly will be possible.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.