[Bug 793268] New: debug-viewer: crash when loading model in timeline

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793268

            Bug ID: 793268
           Summary: debug-viewer: crash when loading model in timeline
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-devtools
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: philn at igalia.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Traceback (most recent call last):
  File "./gst-debug-viewer", line 68, in <module>
    main ()
  File "./gst-debug-viewer", line 65, in main
    GstDebugViewer.run ()
  File
"/home/phil/gst-build/subprojects/gst-devtools/debug-viewer/GstDebugViewer/Main.py",
line 82, in main
    paths=Paths)
  File
"/home/phil/gst-build/subprojects/gst-devtools/debug-viewer/GstDebugViewer/Common/Main.py",
line 506, in main
    options["main"](options)
  File
"/home/phil/gst-build/subprojects/gst-devtools/debug-viewer/GstDebugViewer/GUI/__init__.py",
line 42, in main
    app.run()
  File
"/home/phil/gst-build/subprojects/gst-devtools/debug-viewer/GstDebugViewer/GUI/app.py",
line 135, in run
    Common.Main.MainLoopWrapper(Gtk.main, Gtk.main_quit).run()
  File
"/home/phil/gst-build/subprojects/gst-devtools/debug-viewer/GstDebugViewer/Plugins/Timeline.py",
line 316, in do_draw
    self.__update_params()
  File
"/home/phil/gst-build/subprojects/gst-devtools/debug-viewer/GstDebugViewer/Plugins/Timeline.py",
line 420, in __update_params
    model.get(tree_iter, model.COL_TIME, model.COL_THREAD))
  File "/usr/lib/python2.7/dist-packages/gi/overrides/Gtk.py", line 901, in get
    values.append(self.get_value(treeiter, col))
TypeError: unknown type (null)


I tracked the issue down to the "thread" column model handling. If the thread
id isn't converted to an integer, there's no crash:

diff --git a/debug-viewer/GstDebugViewer/Data.py
b/debug-viewer/GstDebugViewer/Data.py
index 567c018..090b2c0 100644
--- a/debug-viewer/GstDebugViewer/Data.py
+++ b/debug-viewer/GstDebugViewer/Data.py
@@ -392,7 +392,7 @@ class LogLine (list):
         # PID.
         line[1] = int(line[1])
         # Thread.
-        line[2] = int(line[2], 16)
+        # line[2] = int(line[2], 16)
         # Level (this is handled in LineCache).
         line[3] = 0
         # Line.

I'm really not a GTK+ expert but this might be a bug elsewhere, perhaps in
python-gobject. I use version 3.26.1-2 on Debian Testing FWIW.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.