[Bug 793271] v4l2object: Check for all allocators and pools in query

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Feb 7 18:57:10 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=793271

--- Comment #4 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
(In reply to Víctor Manuel Jáquez Leal from comment #3)
> (In reply to Nicolas Dufresne (stormer) from comment #2)
> > Ok, I see why you wanted this in 793270 now. There was an open question if
> > it was ever correct to add a DMABuf allocator (for the case there is no
> > alloc/custom) in the allocation query. I think if the answer is no, then
> > until we have a non-custom dmabuf allocator, this is a bit speculative.
> 
> Agree, a dmabuf allocator with a custom alloc, as the gstreamer-vaapi case,
> might no be right to share it. I can remove it from the query in
> gstreamer-vaapi :)

And looking at the implementation, it's not used.

> 
> > For the pool option, well, an option is supposed to be explicitly enabled by
> > the user. So the usage is a bit of a clash if enabling it have no effect
> > (it's already enabled).
> 
> If enabled and downstream doesn't provide a dmabuf-enable pool or allocator,
> it fails.

Make sense. Shall we add code to enable it though ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list