[Bug 793271] v4l2object: Check for all allocators and pools in query

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Feb 8 09:09:45 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=793271

--- Comment #6 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
(In reply to Nicolas Dufresne (stormer) from comment #4)
> (In reply to Víctor Manuel Jáquez Leal from comment #3)
> > Agree, a dmabuf allocator with a custom alloc, as the gstreamer-vaapi case,
> > might no be right to share it. I can remove it from the query in
> > gstreamer-vaapi :)
> 
> And looking at the implementation, it's not used.

Removed. I have updated the patches for vaapi pool to ignore any non-vaapi
allocator and try to reuse the already set allocator, if there's one.

> > > For the pool option, well, an option is supposed to be explicitly enabled by
> > > the user. So the usage is a bit of a clash if enabling it have no effect
> > > (it's already enabled).
> > 
> > If enabled and downstream doesn't provide a dmabuf-enable pool or allocator,
> > it fails.
> 
> Make sense. Shall we add code to enable it though ?

IMO, if the user request a specific io-mode an it's not achieved, the pipeline
should fail.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list