[Bug 747606] v4l2: adding cropping and compose functionality

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747606

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #368154|none                        |needs-work
             status|                            |

--- Comment #11 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 368154:
 --> (https://bugzilla.gnome.org/review?bug=747606&attachment=368154)

::: sys/v4l2/gstv4l2object.c
@@ +457,3 @@
+   */
+  g_object_class_install_property (gobject_class, PROP_CENTER_CROP,
+      g_param_spec_boolean ("hw-center-crop", "Hardware Center Crop",

Doc and property name miss-match.

In the widget libraries this would be more flexitly, you basically choose the
gravity / direction. Like top-left, center-left, center, center-right, or using
using NORTH/SOUTH/EAST/WEST, etc. This sound much superior.

You also need to document the interection with the crop/render rectangles. If
the hardware can scale, will this scale ? What the default ? How does this
interact with the output format selected in caps ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.