[Bug 790752] msdk: supports bufferpool

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Feb 8 19:47:53 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=790752

sreerenj <bsreerenj at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #368110|needs-work                  |reviewed
             status|                            |

--- Comment #76 from sreerenj <bsreerenj at gmail.com> ---
Review of attachment 368110:
 --> (https://bugzilla.gnome.org/review?bug=790752&attachment=368110)

lgtm

::: sys/msdk/gstmsdkcontext.c
@@ +178,3 @@
+  GstMsdkContext *obj = g_object_new (GST_TYPE_MSDK_CONTEXT, NULL);
+
+  return gst_msdk_context_open (obj, hardware) ? obj : NULL;

Actually gst_msdk_context_open() is un-reffing the context in all failure
cases.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list