[Bug 790752] msdk: supports bufferpool

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=790752

--- Comment #83 from Hyunjun Ko <zzoon at igalia.com> ---
(In reply to sreerenj from comment #75)
> Review of attachment 368108 [details] [review]:
> 
> ::: sys/msdk/msdk.c
> @@ +42,3 @@
> +  GstVideoFormat format;
> +  gint mfx_chroma_format;
> +  gint mfx_fourcc;
> 
> Would it be better to use the MFX defined types here?
> mfxU16 ChromaFormat;
> mfxU32 FourCC;
> 

That would be better for me too.

> @@ +446,3 @@
> +  mfx_info->AspectRatioW = GST_VIDEO_INFO_PAR_N (info);
> +  mfx_info->AspectRatioH = GST_VIDEO_INFO_PAR_D (info);
> +gint
> 
> We should fix this. But I am fine adding it later in a separate patch.

Agree. Currently the interlace mode that msdk elements allow is only
progressive. We can file about this.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.