[Bug 768248] vaapiencode: Add Encoding region-of-interest (ROI) support

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Feb 12 16:19:27 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=768248

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
                 CC|                            |nicolas at ndufresne.ca
         Depends on|                            |793338
         Resolution|FIXED                       |---
           Severity|enhancement                 |blocker

--- Comment #56 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
I'm reopening this one since I think the custom event has design issues. It
does not support ROI hierarchy, does not have ROI ID (making removal
ambiguous), removing ROI requires keeping state and setting again the ROI which
is highly error prone.

I believe this should use GstVideoRegionOfInterestMeta with the proposal at
https://bugzilla.gnome.org/show_bug.cgi?id=793338 . Just a reminder that as a
mainline repository, it's important to think about feature to be generally
useful. This custom event was done a bit "downstream" style.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list