[Bug 784530] GStreamer no longer plays Vorbis streams with incorrectly framed headers

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784530

--- Comment #12 from Edward Hervey <bilboed at bilboed.com> ---
That commit is indeed the culprit. A simple "workaround" is to put vorbisparse
just before which will discard any extra headers.

How are we even meant to fix this ?

I would propose to *accumulate* the (potentially) new headers. According to the
vorbis specification there should *always* be 3 headers.

So:
* If a new header comes in, store it
* Once we get a non-header packet:
** check that we indeed have 3 pending headers *and* that they are the expected
types (1, 3, 5). If so, reset and process those headers
** If we don't have 3 headers, or they are not the expected type, do not reset
and just discard them

This should workaround any potential reconfiguration.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.