[Bug 786403] gstlibav.la contains references to -lbz2 for android

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=786403

--- Comment #14 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
(In reply to Nicolas Dufresne (stormer) from comment #12)
> Review of attachment 368284 [details] [review]:
> 
> That seems incomplete, FFMPEG still depends on zlib and bzip2, which is now
> completely absent from the .la file.

The resulting .la file still has references to libz.la and libbz2.la so they're
not 'completely absent'

(In reply to Nicolas Dufresne (stormer) from comment #13)
> Can you document what adds this .la file, since it's not us, there must be
> something else, cerbero recipe ? I bet this will break other platform,
> that's why I comment negatively on this patch. But if you want to try it out
> on the CI go for it.

'this .la file' == libgstlibav.la ?  The one you added to the gst-libav
Makefile as a result of removing the .la generator from cerbero?
https://cgit.freedesktop.org/gstreamer/gst-libav/log/gst-libs/ext/Makefile.am
and
https://cgit.freedesktop.org/gstreamer/cerbero/commit/recipes/gst-libav-1.0.recipe?id=afd2f5017c16203a5c152e5771bc2599901f128c

> If you give a try to the original static libs resolver, libtool, it will
> handle -l the same as any .la reference (by finding a static lib first).
> This is also what our replicate is supposed to do, though apparently it
> didn't work, or wasn't happy to have a duplicate.

The replicator is a dumb Makefile substitution which doesn't know anything
about external libraries and so does not know how to transform -lz into
/path/to/libz.la and thus copies the -lz and BZ2_LIBS (-lbz2) directly into the
resulting libgstlibav.la.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.