[Bug 786320] vaapih264enc: disable periodic keyframe

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=786320

--- Comment #14 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
(In reply to Matteo Valdina from comment #13)
> Thanks for your comments.
> 
> About the comment:
> "
> Another bug there is that we are saying that 0 is auto-calculate but we are
> not allowing to set zero since 1 is the minimal value permitted.
> "
> 
> This is another separate pre-existing bug. I can easily update the comment
> from "Maximal distance between two keyframes (0: auto-calculate)" to
> "Maximal distance between two keyframes".
> 
> I didn't see the code to auto calculate the keyframes distance, so, the zero
> case looks like is not implemented.

Yes, indeed.

But a default value is generated  here 

https://cgit.freedesktop.org/gstreamer/gstreamer-vaapi/tree/gst-libs/gst/vaapi/gstvaapiencoder.c#n818

The code is a bit convoluted but it ends up as the default value of the
idr_period (1 keyframe per second) if the idr_period is lower than that.

But you are right, leave that for another bug. We shall not mix things.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.