[Bug 793492] GstAudioConverter: improve bindability

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Feb 15 19:30:30 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=793492

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tsaunier at gnome.org

--- Comment #16 from Thibault Saunier <tsaunier at gnome.org> ---
(In reply to Sebastian Dröge (slomo) from comment #15)
> (In reply to Mathieu Duponchelle from comment #9)
> > (In reply to Thibault Saunier from comment #6)
> > > Review of attachment 368381 [details] [review] [review] [review]:
> > > 
> > > Why is it necessary? Is it really the expected behaviour to get a copy of it?
> > 
> > The alternative is to refcount it and ideally make it thread safe, this
> > would be possible but Sebastian was of the opinion that there was no real
> > use case for that
> 
> Refcounting comes with its own set of problems and increases complexity (for
> users as well as bindings: consider the thread-safety traits in Rust and
> their interaction with refcounting for example), and GstAudioConverter
> should not really be shared in different places. You use it from one place,
> otherwise you'll run into interesting problems due to it having a sample
> history, etc.

Right, it is a bit weird to copy to me, but makes things simpler, so let's go
with that.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list