[Bug 786320] vaapih264enc: disable periodic keyframe

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Feb 16 07:59:40 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=786320

--- Comment #16 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
(In reply to Matteo Valdina from comment #15)
> Created attachment 368389 [details] [review]
> Patch for extend max value for periodic key frame (G_MAXUINT32).
> 
> Hi,
> I update the original patch with G_MAXUINT32. 
> 
> I saw that the current code will perform something like:
> 
> if (encoder->idr_period > G_MAXUINT32)
>   encoder->idr_period = G_MAXUINT32;
> 
> This if statement is not really needed because idr_period is a guint32 so it
> cannot be true.
> Anyway, I didn't change because idr_period could be changed in the future.
> 
> If you want I can remove the unneeded check.

Yes, please remove those lines. Thanks.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list