[Bug 793523] New: matroskademux: Add comment about Opus clipping

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793523

            Bug ID: 793523
           Summary: matroskademux: Add comment about Opus clipping
    Classification: Platform
           Product: GStreamer
           Version: unspecified
                OS: All
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: aboya at igalia.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

When I first read this code I thought somebody had forgot about the declared
sample rate and just assumed it to always be 48000 Hz in matroskademux.

Some days passed, and I was working on a opusparse bug when I again found the
48000 magic number. That made me suspicious. I tried encoding some audio at
24000 Hz. It worked, but why? I kept looking and finally I read the opusdec
code where the actual sample clipping was done. Then I knew and everything was
obvious.

This patch is for the me of the past who did not.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.