[Bug 791637] msdk: encode: Add more tuning options

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=791637

--- Comment #18 from Hyunjun Ko <zzoon at igalia.com> ---
(In reply to sreerenj from comment #17)
> > ::: sys/msdk/gstmsdkh265enc.c
> > @@ +188,3 @@
> >  
> > +  gobject_class->set_property = gst_msdkh265enc_set_property;
> > +  gobject_class->get_property = gst_msdkh265enc_get_property;
> > 
> > As this is a pattern that repeats in several encodesr (h265, mpeg2 and vp8)
> > I would add helper functions in the base case for set and get properties:
> > 
> > g_object_class->set_property = gst_msdkenc_set_property;
> > g_object_class->get_property = gst_msdkenc_get_property;
> 
> There are other routines like this we can move too. But I think it is better
> to keep everything simple like other gstreamer elements than providing
> helper function like we did in gstreamer-vaapi.

+1. Align myself with Sree for this.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.