[Bug 793458] omxvideoenc: make GST_PARAM_MUTABLE_PLAYING property thread safe

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Feb 21 16:04:32 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=793458

--- Comment #8 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 368692:
 --> (https://bugzilla.gnome.org/review?bug=793458&attachment=368692)

::: omx/gstomxvideoenc.c
@@ +1015,3 @@
       break;
     case PROP_TARGET_BITRATE:
+      GST_OBJECT_LOCK (self);

Looks good, but in general we protect all properties regardless, so we don't
forget when they get promoted.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list