[Bug 791479] msdkenc: Support force-keyunit events

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=791479

--- Comment #6 from sreerenj <bsreerenj at gmail.com> ---
(In reply to Tim-Philipp Müller from comment #4)
> Comment on attachment 368685 [details] [review]
> msdk: enc: support force key unit event
> 
> >+    /* Force key-frame if needed */
> >+    if (GST_VIDEO_CODEC_FRAME_IS_FORCE_KEYFRAME (input_frame))
> >+      thiz->enc_cntrl.FrameType =
> >+          MFX_FRAMETYPE_I | MFX_FRAMETYPE_IDR | MFX_FRAMETYPE_REF;
> >+    else
> >+      thiz->enc_cntrl.FrameType = MFX_FRAMETYPE_UNKNOWN;
> 
> Not that I know how this API works, but shouldn't this be just
> 
>  thiz->enc_cntrl.FrameType = MFX_FRAMETYPE_IDR;
> 
> ?

Ideally yes, but the above code is what I have seen in msdk sample application.
If a particular use case is already implemented in msdk sample application, I
prefer to stick with same code since they (msdk developers) might have
assumptions based on it :)
I have seen cases like that for
eg:https://github.com/Intel-Media-SDK/samples/issues/13

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.