[Bug 793717] webrtcbin-test: rename of misleading variable name

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Feb 22 15:49:41 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=793717

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #368748|none                        |needs-work
             status|                            |

--- Comment #1 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 368748:
 --> (https://bugzilla.gnome.org/review?bug=793717&attachment=368748)

::: tests/check/elements/webrtcbin.c
@@ +108,3 @@
 {
   struct test_webrtc *t = user_data;
+  GstElement *offeror = t->offerer == 1 ? t->webrtc1 : t->webrtc2;

Shouldn't you rename the element pointer here ? Also, the the guint, I think we
should try and find a two word name that means something.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list